search

authpass / kdbx.dart

KeepassX format implementation in pure dart.
GNU General Public License v3.0
37 stars 12 forks source link

Typo in UsageCount XML tag #1

Closed keepassium closed 3 years ago

keepassium commented 4 years ago

In KdbxTimes, the usage count tag is written as Usagecount. It should be UsageCount instead, with capital "C".

As it is, other apps likely won't find the counter and this would cause issues with DB merging.

hpoul commented 4 years ago

good catch, seems like a typo. Although to be honest I'm not really using that right now anyway.

Is it used in Keepassium? I haven't quite found where it would get incremented.. https://github.com/keepassium/KeePassium/search?q=usagecount&unscoped_q=usagecount

keepassium commented 4 years ago

Yeah, I also did not take it seriously at first. I just assumed it was something to sort entries by frequency of use maybe :)

Apparently, this counter and last access/modification timestamps are required for tracking and merging changes between conflicting versions of the same database.

In KeePassium, the usage counter is updated here and here. I'm not sure why GitHub does not find these lines...

hpoul commented 3 years ago

forgot to close that issue, fixed for a while now https://github.com/authpass/kdbx.dart/commit/f230d1a7dbd9732f238ec33104db43fbb6468cf0 Although it still is never actually increased, neither in kdbx.dart nor in AuthPass. I basically rely on the timestamps for merging 🤔️