search

authzed / authzed-java

Official SpiceDB client library for JVM languages
https://docs.authzed.com/reference/api
Apache License 2.0
19 stars 7 forks source link

BRT-2708 - Dependabot integration #34

Closed marduk216 closed 1 year ago

marduk216 commented 1 year ago

Refs ticketID Please provide the ticket id eg.: BRT-2708

Changes Adding the CODEOWNERS file and the dependabot.yml

Test plan peer review. take a look if the changes are made correctly

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

marduk216 commented 1 year ago

Hey! Thanks for the contribution, asking for a few changes:

  • can you clarify what the number in the title means?
  • let's leave CODEOWNERS in the root directory, so it's aligned with the rest of authzed repositories, and please remove your internal team as owner
  • please remove ./idea from gitignore, we try to stay away from opinionated developer tooling, specially given git lets folks define their own local .gitignore.
  • dependabot file looks good 👍🏻

Hey vroldanbet!

It looks like I have made a mistake. I made this commit in the wrong repository. The name was very confusing because we used it as a 3th party tool. So I will close the PR and sorry for it once again.

Thanks.

vroldanbet commented 1 year ago

@marduk216 got it! Ideally, you don't have to keep your own fork and we can have this changes upstream 😄