Use stable name for SpiceDB containers

authzed / spicedb-operator

Kubernetes controller for managing instances of SpiceDB

Apache License 2.0

62 stars 26 forks source link

Use stable name for SpiceDB containers #196

Closed bison closed 1 year ago

bison commented 1 year ago

This uses a stable name of spicedb for SpiceDB containers in generated Deployment objects. This makes applying patches to things inside the container definitions, like resources requests, much easier.

bison commented 1 year ago

Sounds good. Couple of questions:

Do we only care about patches with type Deployment or just try to unmarshal any patch as an applyappsv1.DeploymentApplyConfiguration and look for the container name?
I guess we don't need to worry about JSON6902 patches, right?
Should the operator actually write the updated name back to the Spec or just log a warning? I've always avoided the former, but I'm not sure what's best here.

ecordell commented 1 year ago

We only care about patches of type: Deployment since those are the only ones that could have used the old names
I think technically we do need to worry about json6902 patches, but it might be a simple as a find/replace with the old container name?
I don't think the operator should write the name back, just a status message saying what it did

bison commented 1 year ago

@ecordell: That makes sense. Why don't we merge this and create an issue for that?