authzed / spicedb-operator

Kubernetes controller for managing instances of SpiceDB
Apache License 2.0
61 stars 24 forks source link

expose port 50052 (readonly-grpc) #286

Closed eliezio closed 5 months ago

github-actions[bot] commented 5 months ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

josephschorr commented 5 months ago

@eliezio What is the intention in exposing this port? Readonly mode is only available in serve-testing mode, which the operator doesn't run

eliezio commented 5 months ago

@eliezio What is the intention in exposing this port? Readonly mode is only available in serve-testing mode, which the operator doesn't run

you're right. I misunderstood the --readonly-grpc-addr flag only applies to serve-testing mode. Canceling this MR...