secret hash is not provided on CR validation error - Githubissues

authzed / spicedb-operator

Kubernetes controller for managing instances of SpiceDB

Apache License 2.0

62 stars 26 forks source link

secret hash is not provided on CR validation error #38

Closed vroldanbet closed 2 years ago

vroldanbet commented 2 years ago

While testing invalid CRs I noticed that the error message misses the secret hash:

https://github.com/authzed/spicedb-operator/blob/cc6d4ac2734579d362c517f553d539177ac3f5a1/pkg/controller/handlers/validate_config.go#L55

An example error generated:

Error validating config with secret hash "": cannot set replicas > 1 for memory engine

ecordell commented 2 years ago

This was fixed by #52

https://github.com/authzed/spicedb-operator/blob/930414254dbd51d81da784bbc7d7a7cf85bb1abd/pkg/controller/validate_config.go#L46