search

authzed / spicedb

Open Source, Google Zanzibar-inspired permissions database to enable fine-grained authorization for customer applications
https://authzed.com/docs
Apache License 2.0
4.94k stars 266 forks source link

re-enable async logging #889

Open vroldanbet opened 1 year ago

vroldanbet commented 1 year ago

cobrautil/v2 async logger was introduced in https://github.com/authzed/spicedb/pull/844 and then disabled in https://github.com/authzed/spicedb/pull/888. Currently there is no means to prevent log from being lost on process termination because the corresponding log buffer is not being flushed.

Reintroduce async log, making sure we can flush out when the process is terminating.

vroldanbet commented 1 year ago

We might be able to re-enable it if we leverage the new closeables implemented in RunnableServer