Count only visible lines for popup direction

auto-complete / popup-el

Visual Popup Interface Library for Emacs

GNU General Public License v3.0

445 stars 96 forks source link

Count only visible lines for popup direction #111

Closed drvink closed 4 years ago

drvink commented 7 years ago

This prevents the popup from displaying past the end of a window in GUI Emacs.

jcs090218 commented 4 years ago

Can you elaborate this more? How do you reproduce the issue? Thanks! :)

drvink commented 4 years ago

Wow, this PR was a while ago.

The issue here is that window-height already includes the heights of the mode and header lines. Therefore, you want to use window-text-height; otherwise you're including the mode and/or header lines twice.

jcs090218 commented 4 years ago

Merged! Thanks! :)