auto-complete / popup-el

Visual Popup Interface Library for Emacs
GNU General Public License v3.0
445 stars 96 forks source link

do NOT hide tab bar of tab-bar-mode when popup-menu* executeing. #144

Open khiker opened 3 months ago

khiker commented 3 months ago

Problem:

when popup-menu is executed, popup-menu hides tab bar when tab-bar-mode is t.

Expected:

when executing popup-menu*, do not hide tab bar if tab-bar-mode is t.

Reproduce:

(tab-bar-mode t) ;; -> show tab-bar
(require 'popup)
(popup-menu* '(a b)) ;; → hide tab-bar

Cause:

  1. popup-menu-read-key-sequence replaces current global-map to temp-global-map temporarily.
  2. temp-global-map do not have tab-bar's map.
  3. so, tab-bar disappears when popup-menu* executes.

Fix:

add tab-bar's map to temp-global-map same as menu-bar and tool-bar.

Environment;

Emacs 29.3 Debian GNU/Linux sid (6.7.12-amd64)

popup-el-and-tab-bar