auto-optimization / eafpy

https://auto-optimization.github.io/eafpy/
Other
1 stars 0 forks source link

eaf3d.c not compatible with MSVC due to using VLAs #12

Closed FergusRooney closed 1 year ago

FergusRooney commented 1 year ago

EAF3d uses VLA which are not supported by MSVC windows compiler - see here. This means that the eaf C function will not compile on windows. The options are either:

  1. Change eaf3d.c to use dynamic allocation instead of VLA. I have started some work on this but it is not working this branch
  2. Change windows compiler to MinGW32. I have had some success with this, however I cannot work out how to conditionally change the compiler, so this will not work on linux. The compiler is selected in this setup.cfg file. Also, I am getting slightly different results when calculating a 3d eaf in MINGW32 version compared to Linux GNU GCC version
MLopez-Ibanez commented 1 year ago

Fixed by 79f076f