auto-ssl / lua-resty-auto-ssl

On the fly (and free) SSL registration and renewal inside OpenResty/nginx with Let's Encrypt.
MIT License
1.93k stars 182 forks source link

Deploy an OPM package? #45

Open brendon opened 7 years ago

brendon commented 7 years ago

According to the LuaRocks page, its use is now discouraged:

http://openresty.org/en/using-luarocks.html

Would you be interested in releasing an OPM package also? :)

GUI commented 7 years ago

I'm interested in publishing to OPM (I've published my other lua-resty module to OPM), but lua-resty-auto-ssl's installation process currently builds the C library sockproc, and OPM doesn't yet support compiling C components (although it's on their TODO list): https://github.com/openresty/opm/issues/30

So I had been waiting on support for building C things to land in OPM before publishing lua-resty-auto-ssl to OPM.

That being said, we could technically publish lua-resty-auto-ssl to OPM, but without sockproc. You'd then have to manually build and install sockproc yourself, so I'm not sure it would be more convenient. But let me know if that seems preferable.

brendon commented 7 years ago

I don't really have an opinion either way. I found the luarocks method easy enough :)

It was just the warning message on the openresty website that prompted me to ask :) This can probably serve as an answer to others in the meantime until OPM supports everything you need.

luto commented 7 years ago

Since OPM seems to be the direction openresty itself is moving, we should keep this open as a tracking bug. But can't actually implement anything until the C support in OPM is done.

byrnedo commented 6 years ago

Any idea when this might be done? Is the best way in the meantime to install manually?

GUI commented 6 years ago

@byrnedo: Using LuaRocks is still the preferred installation method for lua-resty-auto-ssl. Until OPM has C support, there's still various things, like lua-resty-auto-ssl, that can't be installed via OPM. So while OpenResty prefers OPM these days, LuaRocks still works great and is still the de facto package manager actively supported by the broader Lua community.

But since LuaRocks doesn't come bundled with OpenResty, you will need to install it first: http://openresty.org/en/using-luarocks.html#install-luarocks

byrnedo commented 6 years ago

Thanks for the explanation. I'll go with lua-rocks then!

On 1 October 2017 at 16:07, Nick Muerdter notifications@github.com wrote:

@byrnedo https://github.com/byrnedo: Using LuaRocks is still the preferred installation method for lua-resty-auto-ssl. Until OPM has C support, there's still various things, like lua-resty-auto-ssl, that can't be installed via OPM. So while OpenResty prefers OPM these days, LuaRocks still works great and is still the de facto package manager actively supported by the broader Lua community.

But since LuaRocks doesn't come bundled with OpenResty, you will need to install it first: http://openresty.org/en/using- luarocks.html#install-luarocks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GUI/lua-resty-auto-ssl/issues/45#issuecomment-333378971, or mute the thread https://github.com/notifications/unsubscribe-auth/AFRbqw-FF17aH5uX0VHI-ZfApaDITgmpks5sn5yEgaJpZM4L81DQ .

aftabnaveed commented 5 years ago

But since LuaRocks doesn't come bundled with OpenResty, you will need to install it first: http://openresty.org/en/using-luarocks.html#install-luarocks

This is discouraged by openresty and I am just wondering if still using the luarock would have any implications?

brendon commented 5 years ago

It shouldn't. It works fine for me in my production environment. I think it's discouraged because they want to shift people to OPM packages.

kajmagnus commented 5 years ago

Maybe mention all this briefly in the readme? I'm thinking everyone who takes a closer look at lua-resty-auto-ssl will get slightly confused about using LuaRocks, although deprecated — slightly gave me the incorrect impression that lua-resty-auto-ssl wasn't being kept up-to-date. And not everyone will find this discussion and explanation.

Example:

Requirements: ... LuaRocks (LuaRocks is deprecated, but OpenResty's new package manager, OPM, cannot currently compile C components)