search

autoNumeric / autonumeric.github.io

This is the compiled version of the official AutoNumeric website (http://autonumeric.org). To contribute to the code, checkout the source repository:
https://github.com/autoNumeric/autonumeric.org
1 stars 1 forks source link

Modify the pages to be responsive on mobile #2

Open AlexandreBonneau opened 7 years ago

AlexandreBonneau commented 7 years ago

The landing page is awful on small screen. Fix that.

UnusualSoul commented 6 years ago

Is this project still active?

AlexandreBonneau commented 6 years ago

As you can see by the response time, yes it is, in a way :)

However since I cannot approach the speed of light to slow time (and somehow still stay here on Earth !), I haven't found the time to tackle this issue.

Any help is welcome though! 😎

UnusualSoul commented 6 years ago

What you can't approach the speed of light? I thought everybody could do that... maybe it's just me 😃

I'm trying to get the landing page up and I'm having some difficulties, what's the project built with? Anything else I need to know would be helpful!

AlexandreBonneau commented 6 years ago

Ah! The website source code is in the autonumeric.org repository. This autonumeric.github.io repository is only used for the compiled code, served automatically by the github pages.

The underlying technologies for the website are Vue.js and the Quasar Framework. You can check the readme on the repo for build instructions, it's pretty straightforward!

UnusualSoul commented 6 years ago

Ok, making progress... however I can't get the page to load properly. This is what I get when I do "yarn dev" image By chance do you know how to fix this?

AlexandreBonneau commented 6 years ago

Yes I do; the error message is pretty explicit though : Expected linebreaks to be 'LF' but found 'CRLF'. :)

This means the code editor your are using is very unpolite and uses the windows-only 'new line' characters (\r\n), instead of respecting the one already setup in the files (\n).

Luckily, eslint caught that error and warned you; it would have been a pain to see which line your commit changed if all the lines are modified by that editor.

I would suggest using one of those smart code editors (in that order):

UnusualSoul commented 6 years ago

So that's what I read online too. I just wasn't sure how to fix it. Although I don't understand how this is the code editors fault. I haven't change any code or anything at this point.

AlexandreBonneau commented 6 years ago

Some editors just have a default newline character setup, and just update all of those on save. If you see such editor, report it to the police though ;)

UnusualSoul commented 6 years ago

Right, however I haven't opened a text editor or saved/changed any files yet either. This is happening in the initial build.

What I've done so far: Fork the repository Open GIT Bash cd /where my github files go Clone repository to my machine cd /where my github files go/autonumeric.org (yarn's already installed so I skipped that step) yarn - it gets all the dependencies and packages correctly yarn dev - which is when I get the error

Just so you know I'm trying to figure this out myself too. I'm not just bugging you for support. XD

AlexandreBonneau commented 6 years ago

It's ok :)

Well, I stopped using Windows so long ago, I can only make conjectures about what has gone wrong here unfortunately.

Have you tried within WSL?

UnusualSoul commented 6 years ago

Ok, so I got it... I opened the file associated with the error in Sublime Text 2 then went view > line endings > Unix for each one then saved the file. I feel like there's probably an easier way than that but I only had to do it for about 10 files. Now I can finally get started! Thanks for the help!

UnusualSoul commented 6 years ago

Do you want me to create a PR here or create an issue and PR at autonumeric.org instead?

AlexandreBonneau commented 6 years ago

It would be preferable on the autonumeric.org repository indeed.

Just link the new issue to this one then.

Also, thanks ;)