search

autobrr / autobrr

Modern, easy to use download automation for torrents and usenet.
https://autobrr.com/introduction
GNU General Public License v2.0
1.33k stars 122 forks source link

ruTorrent missing torrent comment when added via autobrr / rtorrent xmlhttprpc #1588

Open MasalaTalk opened 2 months ago

MasalaTalk commented 2 months ago

Hi,

I set up autobrr for using RSS feeds on tik and while it adds torrent to the client, it removes the comment part which contains link to the torrent page. RSS feed directly in client is working fine. but through autobrr comments is missing. is it the character limit issue? because their comment has long sentence followed by torrent link : "Sourced from tik; thank you for not redistributing this torrent file and for seeding generously. "

let me know if you need any further details

Thank you

zze0s commented 1 month ago

Hi! I don't think I follow here. You have a RSS feed and that part works and it successfully adds the torrent to your client, but it misses the comment? What comment is that? The one part of the torrent or the feed?

MasalaTalk commented 1 month ago

torrent comment contains url to the torrent page. I'm talking about that part. it's part of the torrent and not part of feed.

zze0s commented 1 month ago

torrent comment contains url to the torrent page. I'm talking about that part. it's part of the torrent and not part of feed.

I can't replicate this. I grabbed a torrent and edited the comment part to your string and a long url and exported with torrenttools and then open that like we do in autobrr and it reads correctly, but we don't even modify the .torrent. It's downloaded and creates a .torrent file straight from the bytes it downloads.

I added the same modified torrent to qBittorrent (v4.6.2) and the long comment is in there. What version are you running?

Not really sure what to test without access to the exact data. If you want to debug this further and a bit more live you can join our Discord and find me there.

zze0s commented 3 weeks ago

Update:

This turned out to be for r(u)torrent and other clients works as expected.

I spent a couple of hours trying to figure this out and from what I can tell this happens when autobrr sends to rtorrent via ruTorrent/xmlhttprpc which sends directly to rtorrent.

As far as I can tell, rtorrent does not handle Comments as part of the .torrent file. ruTorrent does that however, so when a torrent is added directly inside ruTorrent manually or via RSS feed it works because it can read the Comment of .torrent files.

A possible fix for this would be to add a new download client specifically for ruTorrent which uses it's apis instead of the current way which proxies to the rtorrent backend.

Alternatively maybe check with the current r(u)torrent maintainer Stickz/vertex if they know if this is a bug or intended and willing to change that behavior/functionality.

MasalaTalk commented 3 weeks ago

Thanks for your time and effort!!