search

autobrr / omegabrr

Omegabrr transforms monitored shows, movies, books and music from arrs into autobrr filters. It also supports adding titles from custom lists to autobrr filters.
https://autobrr.com
MIT License
135 stars 11 forks source link

fix(tags): exclude non-specified #43

Closed s0up4200 closed 1 year ago

s0up4200 commented 1 year ago

Previously, omegabrr was adding all monitored shows/movies to the list, regardless of whether they had the specified tags in tagsInclude. With this PR, omegabrr will now only add shows/movies with the tag(s) specified in tagsInclude in config.yaml.

If tagsInclude is not used, all monitored shows/movies (except those part of tagsExclude) will be added to the list.

bakerboy448 commented 1 year ago

This logic should (be tweaked if necessary) allow both to work at the same time and the filters operate as AND. IMO

Initially filter include all series for only tagsInclude Then remove any series that exist in tagsExclude

s0up4200 commented 1 year ago

Are you referring to a scenario where a show has tags in both tagsInclude and tagsExclude? Those are not added to autobrr.

EDIT: Answered and confirmed on Discord

zze0s commented 1 year ago

Are you referring to a scenario where a show has tags in both tagsInclude and tagsExclude? Those are not added to autobrr.

EDIT: Answered and confirmed on Discord

What was the conclusion here? Needed or not?

s0up4200 commented 1 year ago

This PR isn't needed. The program is already functioning as intended.

If tagsInclude is used, then only titles with those tags are added. If the titles also have a tag specified in tagsExclude, it will be excluded.