search

autodesk-cloud / ochopod

Your friendly orchestration overlay over Mesos, K8S and more !
http://autodesk-cloud.github.io/ochopod/
Apache License 2.0
122 stars 20 forks source link

Support wildcard character (*) for looking up dependencies. #32

Closed pferrot closed 8 years ago

opaugam commented 8 years ago

good stuff patrice - i really like the fact you are matching the coding style nicely :)

Q : did you test it out in a real-life use-case ? i'm curious to see if there is any potential performance issue ? looks good in any case.

Q2 : do we need a full blown regex match or can/should we use the trimmed-down fnmatch package ?

pferrot commented 8 years ago

I just tested in dev with 4 or 5 clusters. Adding/removing/scaling up or down clusters worked smoothly.

Regarding regex VS fnmatch: both will work, up to you :-)

opaugam commented 8 years ago

awesome - i'll perform a few tests & merge into 1.0.6 later on today !

opaugam commented 8 years ago

yes i'm going to finally include this one :)

opaugam commented 8 years ago

i'm going to merge it manually along with other changes / closing this PR (push coming soon..)

pferrot commented 8 years ago

Awesome, thanks! And I like the "absolute" dependency feature - I am sure that I will use it at some point!