autodesk-forks / MaterialX

MaterialX C++ and Python libraries
http://www.materialx.org/
Apache License 2.0
107 stars 23 forks source link

Change naming convention on intern string class in runtime library. #1193

Closed niklasharrysson closed 3 years ago

niklasharrysson commented 3 years ago

Using the word "identifier" for our intern string class has been deemed to vague. In order to make it more clear what the intern string class is, and how it use it, this change list makes a few changes:

  1. The data type "identifier" is renamed to "internstring" - concretely describing what it is.
  2. The intern string class RtIdentifier is renamed RtString, making it short and sweet and more descriptive.
  3. Class docs has been updated to clarify when to use this class.

This gives us a more consistent naming for string handling in the API, where mx::string is the ordinary string class for general use and mx::RtString is the runtime string class with string interning.