autodesk-forks / MaterialX

MaterialX C++ and Python libraries
http://www.materialx.org/
Apache License 2.0
107 stars 23 forks source link

Procedural Wood #1404

Open Starry316 opened 2 months ago

Starry316 commented 2 months ago

Add a procedural wood material node graph (wood3d) which includes following custom nodes/node graphs as its components:

This commit also contains a 3dwood_prests.mtlx which has many pre-defined parameters that helps to create different types of wood.

zicher3d commented 2 months ago

I see the comments on defs file about the subgraphs with single-use. I'm still of the opinion we should remove them. Let's discuss on slack or in a quick meeting.

zicher3d commented 2 months ago

Just for the record (no need to add anything now). The defs should include a namespace="adsk" like for Prism nodes when final. My Legacy Protein defs also lack the namespace now, and the reason is that there is a bug in Graph Editor that prevents nodes with a namespace to be created. That's reason enough to skip, as it makes working and debugging the nodes basically impossible. But if we are tracking issues in Jira or somewhere else, we should put this in the list.

zicher3d commented 2 months ago

We have a few instances of Graph Editor auto-naming of nodes that are misleading (in sub-graphs). Example: "ray_combine2_vector3", which is a combine 2 floats into a vector2. In many cases the last part (the type, like "_vector3" in the above sample) can always be removed, but doing it now is a bit difficult. This is just for readability, low priority.