autodesk-platform-services / aps-sdk-net

The official APS SDK for .NET.
https://www.nuget.org/profiles/AutodeskPlatformServices.SDK
Apache License 2.0
19 stars 12 forks source link

Bug in ItemPayloadIncludedRelationshipsStorageData serialization #108

Open EMostafaAli opened 5 days ago

EMostafaAli commented 5 days ago

I believe there is a bug in ItemPayloadIncludedRelationshipsStorageData specifically in the following line https://github.com/autodesk-platform-services/aps-sdk-net/blob/e9b599be00f6d38157adb0b8a48b060b07513494/datamanagement/source/Model/ItemPayloadIncludedRelationshipsStorageData.gen.cs#L55-L56

EmitDefaultValue should be true as currently the object is serialized to the following (missing the type property); which in turn causes CreateItemAsync to fail

{
    id = "ID value"
}
Arrotech commented 4 days ago

@EMostafaAli ,

Thanks for reporting. Let us look into the issue and we'll revert back

tylerwarner33 commented 4 days ago

@EMostafaAli that looks to be correct.

The other classes that use the specific type of object (TypeVersion, TypeFolder, etc.) have that set to true & I missed that when submitting PR #101 & just submitted the fix in PR #109:

Arrotech commented 4 days ago

Thanks @EMostafaAli and @tylerwarner33 for reporting and suggesting the fix

The issue has been fixed and will be released ASAP