autodl-community / autodl-rutorrent

ruTorrent plugin for autodl-community fork of autodl-irssi
http://autodl.community
92 stars 23 forks source link

Duplicate download release.. #26

Closed ne0ark closed 7 years ago

ne0ark commented 8 years ago

This option is getting unchecked if you navigate away from the filter it is selected on. Only option to have it selected is to manage filter manually by editing the .cfg file.

ghost commented 7 years ago

I have the same issue, in fact it's present for all the checkboxes for that a filter.

thebigmunch commented 7 years ago

So, another user that had this issue did some testing and discovered that it was an issue caused by the Swizards ruTorrent theme. They and some others that have run into this used the QuickBox install script. I'm guessing that's the cause for everyone's issues, so I'll be closing the issue as it doesn't seem to be caused by autodl-rutorrent itself.

ne0ark commented 7 years ago

This is happening all the themes in rutorrent. I have opened another ticket there hopefully, it will be resolved https://github.com/Novik/ruTorrent/issues/1342 .

thebigmunch commented 7 years ago

Don't actually know if it's true or not since I've still never been able to reproduce this. That's simply one user's experience. When someone debugs it to the point of finding what the cause is, if not that, they can post it here. I'd start by taking a look at the version of jQuery in use in ruTorrent on your system. You can also check in DialogUtils.js to see if any of the jQuery method behaviors have changed over time.

If I could actually reproduce it anywhere myself, I might actually be able to help. But I can't.

Fugor commented 7 years ago

Same issue here, I'll do some testing with themes and look at jQuery and come back.

thebigmunch commented 7 years ago

I ended up giving one last shot at trying to figure out the old Reload button issue. While doing this, I refreshed ruTorrent on my Whatbox slot to their latest fork which I hadn't done in a while. Ran into an unrelated issue with a function being removed in 3.0. So I decided to test this issue. Et voila!. In July, they updated it to use jQuery 3.1. Loaded jquery-migrate into the mix and found 2 or 3 things including the cause of this on newer jQuery versions.

thebigmunch commented 7 years ago

And, why QuickBox installs are specifically displaying this issue is because they don't stick to release versions of ruTorrent.

ne0ark commented 7 years ago

Ah 🎱 . The release is from Oct 16, 2013 I also use SVN for bugfixes. Hopefully, the fix is easy. Thank you for debugging. This might also explain why download duplicate filter never worked properly?

thebigmunch commented 7 years ago

Feel free to check out the jquery-updates branch to test out the fixes.

ne0ark commented 7 years ago

Hmm Issue is still there. My browser console says.

$().jquery
"1.11.3"

https://github.com/Novik/ruTorrent/blob/master/js/jquery.js also shows 1.11.3.

Fugor commented 7 years ago

Feel free to check out the jquery-updates branch to test out the fixes.

I can if you tell me how.

thebigmunch commented 7 years ago

This issue is resolved with the jQuery updates as far as I can tell on all systems I've tested.