search

autofac / Autofac.Extras.AggregateService

Dynamic aggregate service implementation generation for Autofac IoC
MIT License
4 stars 7 forks source link

Correct check for open generic #10

Closed StijnVA closed 3 years ago

StijnVA commented 3 years ago

Using IsGenericTypeDefinition instead of IsGenericType to only register as open generic if it is an actual open generic and not as soon it is a type with a type parameter.

codecov[bot] commented 3 years ago

Codecov Report

Merging #10 (06c8f06) into develop (829b0e6) will increase coverage by 0.14%. The diff coverage is 100.00%.

:exclamation: Current head 06c8f06 differs from pull request most recent head d5b665b. Consider uploading reports for the commit d5b665b to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #10      +/-   ##
===========================================
+ Coverage    97.72%   97.87%   +0.14%     
===========================================
  Files            4        4              
  Lines           88       94       +6     
  Branches        16       17       +1     
===========================================
+ Hits            86       92       +6     
  Misses           1        1              
  Partials         1        1
Impacted Files Coverage Δ
...ac.Extras.AggregateService/ResolvingInterceptor.cs 96.36% <ø> (ø)
...ras.AggregateService/ContainerBuilderExtensions.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 829b0e6...d5b665b. Read the comment docs.

tillig commented 3 years ago

I can get that whiltespace thing when I update the semver.