Bit of a "whoops" on my part based on the previous PR to get things building in .NET 6. Just noticed it as I was updating another net472 project.
In .NET 6 you don't have to reference the analyzer NuGet packages unless you're trying to "pin" versions of the analyzers. It's easier if we let them auto-upgrade. Removed that.
The unit test project had packaging details (README, icon) in it but isn't packaged. Copy/paste oops.
The unit test project did not have AllEnabledByDefault on, so it was only doing minimal analysis. Turning that on revealed we had a few rules for tests turned up more than we need, but also that there were a few things that needed to be fixed from a code perspective.
This is more in line with how we need to get other net472 projects updated, I think, and I'll be using this in Autofac.Mvc.Owin as I update that one.
Bit of a "whoops" on my part based on the previous PR to get things building in .NET 6. Just noticed it as I was updating another net472 project.
AllEnabledByDefaulton, so it was only doing minimal analysis. Turning that on revealed we had a few rules for tests turned up more than we need, but also that there were a few things that needed to be fixed from a code perspective.This is more in line with how we need to get other net472 projects updated, I think, and I'll be using this in Autofac.Mvc.Owin as I update that one.