autofac / Autofac.ServiceFabric

Autofac integration for Azure Service Fabric. Provides service factory implementations for Actors, Stateful Services and Stateless Services.
MIT License
26 stars 27 forks source link

The type 'System.Fabric.StatefulServiceContext' is not assignable to service 'System.Fabric.StatelessServiceContext' #16

Closed artemkuzmyk closed 7 years ago

artemkuzmyk commented 7 years ago

https://github.com/autofac/Autofac.ServiceFabric/blob/590aba5d0b3df1702d3b063b708d2d0615cfb3a4/src/Autofac.Integration.ServiceFabric/ActorFactoryRegistration.cs#L49

Seems like misspelling here Must be: builder.RegisterInstance(context).As<StatefulServiceContext>().As<ServiceContext>();

artemkuzmyk commented 7 years ago

It's a blocker for me to use actor with this libary :(

alexmg commented 7 years ago

Looks like a typo that slipped through in a PR. I'm about to do the 1.0.0 release and this fix will be included. Glad you caught it just in time! 👍

alexmg commented 7 years ago

@artemkuzmyk I've pushed the 1.0.0 release to NuGet that includes this fix. Please let me know if you find any other problems.

artemkuzmyk commented 7 years ago

Good job, thanks