search

autofac / Autofac.ServiceFabric

Autofac integration for Azure Service Fabric. Provides service factory implementations for Actors, Stateful Services and Stateless Services.
MIT License
26 stars 27 forks source link

Package version bump #59

Open WhitWaldo opened 2 years ago

WhitWaldo commented 2 years ago

Package update:

tillig commented 2 years ago

Is there a technical reason for requiring the updates? For example, if you added the explicit references to your own project, would that have the same effect? Generally we don't bump packages unless there's a specific reason because it forces downstream consumers to potentially take an upgrade they don't want yet.

WhitWaldo commented 2 years ago

No hard technical reason for the bump except that it was a precursor to my most recent PR. I guess you could also say that the versions replaced (<6.4) are also marked as deprecated by the Service Fabric team and out of support per their latest release notes (last bullet).

tillig commented 2 years ago

I will admit, I don't use Service Fabric so it's hard for me to make a call here. It roughly appears that the version of the client library you use needs to align with the version of Service Fabric you're running. Is that correct? If I'm running Service Fabric 8.2 will Microsoft.ServiceFabric 9.0.1048 work with that?

If so, awesome. That solves a lot of problems.

If not, it may be that the latest we can update to here is the minimum not-deprecated version so we can let the client application decide what to run.

WhitWaldo commented 2 years ago

As covered in some other issue thread, SF is quite package-specific (if you install Microsoft.ServiceFabric.Data 6.0.1048 and this package uses a different version, you're going to need to install all the related 6.0.1048 packages as well.

I'm not sure if that works backwards (e.g. if Autofac comes with the more recent version and you instead opt to use an older package in full, specifically). I'll have to experiment with that in the next couple of days. Maybe hold on merging this until I can try that out.

tillig commented 2 years ago

I thought I remembered seeing that somewhere. I don't think you can downgrade a package by specifically referencing it, you can only upgrade. That's been my experience at least. Let me know what you find out.

WhitWaldo commented 2 years ago

Nope, it's not ok with downgrades. According to the handy chart then, that puts us at 8.2.1235 for Microsoft.ServiceFabric and 5.2.1235 for all other Service Fabric packages (e.g. Microsoft.ServiceFabric.Services, Microsoft.ServiceFabric.Diagnostics.Internal, etc.) through the end of November, when we'll jump to 9.0.1017 for Microsoft.ServiceFabric and 6.0.1017 for the others.

I'll tweak the PR before the end of the week as I've got some free time. Significant version bump nonetheless.

tillig commented 2 years ago

Oooo, I dig that chart. Good to know it's there.