Closed tillig closed 1 year ago
Base: 77.99% // Head: 77.99% // No change to project coverage :thumbsup:
Coverage data is based on head (
302964e
) compared to base (58e297d
). Patch has no changes to coverable lines.:exclamation: Current head 302964e differs from pull request most recent head a7addde. Consider uploading reports for the commit a7addde to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Looks awesome! I can't approve my own PR so I'll just click the "MAKE IT GO" button. :)
This updates core Autofac to use the cross-platform VS + VS Code capable .resx => .Designer.cs generation. It sets MSBuild as the mechanism for generating the resources and adds a dependency to the build to ensure OmniSharp (VS Code) will generate the same way VS does. If VS detects it needs to run a build, it will; and the outcome will be the same in both VS and VS Code.
.Designer.cs files are removed and .gitignored so they can always be generated into the
obj
folder. Note you can't generate into subfolders ofobj
without manually creating those file paths, which I didn't do. Luckily, all of our .resx files have different names, so there were no conflicts and everything can be generated into the sameobj
folder (but in different namespaces as needed).This is slightly different than the Autofac.Mef updates I recently made, in that we no longer need the weird
<Compile Remove>
directive - I learned a bit more since then and found how to make it better. I have a blog article that talks about it. I'll have to go back and fix the MEF library after this.