autofac / Autofac

An addictive .NET IoC container
https://autofac.org
MIT License
4.44k stars 836 forks source link

Optimize Autofac.Features.OpenGenerics.OpenGenericServiceBinder.TryBindOpenGenericTypedService #1374

Closed SergeiPavlov closed 1 year ago

SergeiPavlov commented 1 year ago

Optimizations:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 :warning:

Comparison is base (1910177) 78.53% compared to head (d703f81) 78.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1374 +/- ## =========================================== - Coverage 78.53% 78.50% -0.04% =========================================== Files 199 199 Lines 5717 5726 +9 Branches 1162 1168 +6 =========================================== + Hits 4490 4495 +5 - Misses 715 717 +2 - Partials 512 514 +2 ``` | [Impacted Files](https://codecov.io/gh/autofac/Autofac/pull/1374?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac) | Coverage Δ | | |---|---|---| | [src/Autofac/Core/InternalReflectionCaches.cs](https://codecov.io/gh/autofac/Autofac/pull/1374?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac#diff-c3JjL0F1dG9mYWMvQ29yZS9JbnRlcm5hbFJlZmxlY3Rpb25DYWNoZXMuY3M=) | `100.00% <100.00%> (ø)` | | | [.../Features/OpenGenerics/OpenGenericServiceBinder.cs](https://codecov.io/gh/autofac/Autofac/pull/1374?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac#diff-c3JjL0F1dG9mYWMvRmVhdHVyZXMvT3BlbkdlbmVyaWNzL09wZW5HZW5lcmljU2VydmljZUJpbmRlci5jcw==) | `88.88% <100.00%> (+0.53%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/autofac/Autofac/pull/1374/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tillig commented 1 year ago

Looks like there may be a couple build/style warnings popping up.