autofac / Autofac

An addictive .NET IoC container
https://autofac.org
MIT License
4.44k stars 836 forks source link

Re-enable RegsiterTypes filtering; better message for RegisterType issues #1389

Closed tillig closed 11 months ago

tillig commented 11 months ago

I'll add some comments to the important bits for extra attention.

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 92.68% and project coverage change: -0.02% :warning:

Comparison is base (dc4e4cd) 78.49% compared to head (36da90d) 78.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1389 +/- ## =========================================== - Coverage 78.49% 78.47% -0.02% =========================================== Files 199 201 +2 Lines 5706 5715 +9 Branches 1166 1169 +3 =========================================== + Hits 4479 4485 +6 - Misses 714 716 +2 - Partials 513 514 +1 ``` | [Files Changed](https://app.codecov.io/gh/autofac/Autofac/pull/1389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac) | Coverage Δ | | |---|---|---| | [src/Autofac/Core/InternalReflectionCaches.cs](https://app.codecov.io/gh/autofac/Autofac/pull/1389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac#diff-c3JjL0F1dG9mYWMvQ29yZS9JbnRlcm5hbFJlZmxlY3Rpb25DYWNoZXMuY3M=) | `100.00% <ø> (ø)` | | | [src/Autofac/Core/Resolving/ResolvePipeline.cs](https://app.codecov.io/gh/autofac/Autofac/pull/1389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac#diff-c3JjL0F1dG9mYWMvQ29yZS9SZXNvbHZpbmcvUmVzb2x2ZVBpcGVsaW5lLmNz) | `80.00% <0.00%> (ø)` | | | [src/Autofac/Core/UniqueService.cs](https://app.codecov.io/gh/autofac/Autofac/pull/1389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac#diff-c3JjL0F1dG9mYWMvQ29yZS9VbmlxdWVTZXJ2aWNlLmNz) | `77.77% <0.00%> (ø)` | | | [.../OpenGenerics/OpenGenericRegistrationExtensions.cs](https://app.codecov.io/gh/autofac/Autofac/pull/1389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac#diff-c3JjL0F1dG9mYWMvRmVhdHVyZXMvT3BlbkdlbmVyaWNzL09wZW5HZW5lcmljUmVnaXN0cmF0aW9uRXh0ZW5zaW9ucy5jcw==) | `68.18% <ø> (ø)` | | | [...fac/Features/OwnedInstances/InstancePerOwnedKey.cs](https://app.codecov.io/gh/autofac/Autofac/pull/1389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac#diff-c3JjL0F1dG9mYWMvRmVhdHVyZXMvT3duZWRJbnN0YW5jZXMvSW5zdGFuY2VQZXJPd25lZEtleS5jcw==) | `60.00% <0.00%> (ø)` | | | [src/Autofac/TypeExtensions.cs](https://app.codecov.io/gh/autofac/Autofac/pull/1389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac#diff-c3JjL0F1dG9mYWMvVHlwZUV4dGVuc2lvbnMuY3M=) | `35.89% <0.00%> (ø)` | | | [src/Autofac/Util/AssemblyExtensions.cs](https://app.codecov.io/gh/autofac/Autofac/pull/1389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac#diff-c3JjL0F1dG9mYWMvVXRpbC9Bc3NlbWJseUV4dGVuc2lvbnMuY3M=) | `40.00% <ø> (-26.67%)` | :arrow_down: | | [...degen/Autofac.CodeGen/DelegateRegisterGenerator.cs](https://app.codecov.io/gh/autofac/Autofac/pull/1389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac#diff-Y29kZWdlbi9BdXRvZmFjLkNvZGVHZW4vRGVsZWdhdGVSZWdpc3RlckdlbmVyYXRvci5jcw==) | `97.63% <66.66%> (ø)` | | | [src/Autofac/Builder/RegistrationBuilder.cs](https://app.codecov.io/gh/autofac/Autofac/pull/1389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac#diff-c3JjL0F1dG9mYWMvQnVpbGRlci9SZWdpc3RyYXRpb25CdWlsZGVyLmNz) | `82.05% <66.66%> (-1.29%)` | :arrow_down: | | [...eatures/Scanning/ScanningRegistrationExtensions.cs](https://app.codecov.io/gh/autofac/Autofac/pull/1389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac#diff-c3JjL0F1dG9mYWMvRmVhdHVyZXMvU2Nhbm5pbmcvU2Nhbm5pbmdSZWdpc3RyYXRpb25FeHRlbnNpb25zLmNz) | `63.07% <66.66%> (-5.35%)` | :arrow_down: | | ... and [29 more](https://app.codecov.io/gh/autofac/Autofac/pull/1389?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/autofac/Autofac/pull/1389/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.