search

autofac / Autofac

An addictive .NET IoC container
https://autofac.org
MIT License
4.44k stars 836 forks source link

Replace MOQ with NSubstitute #1390

Closed aydjay closed 8 months ago

aydjay commented 11 months ago

As per the huge discussion chain here:

https://github.com/moq/moq/issues/1372

Replace MOQ with NSubstitute

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dc4e4cd) 78.49% compared to head (8c32a76) 78.44%. Report is 15 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1390 +/- ## =========================================== - Coverage 78.49% 78.44% -0.06% =========================================== Files 199 201 +2 Lines 5706 5715 +9 Branches 1166 1169 +3 =========================================== + Hits 4479 4483 +4 - Misses 714 717 +3 - Partials 513 515 +2 ``` [see 14 files with indirect coverage changes](https://app.codecov.io/gh/autofac/Autofac/pull/1390/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autofac)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tillig commented 11 months ago

Thanks! I'm going to hold on this a moment and see how this pans out. The current version we're referencing doesn't have the privacy issues noted and, from a short term perspective, we can always just pin <4.20.0 as the package reference. If this changes and a newer version of Moq comes out without this issue, we can "jump" to the new one, still saving some time. And if it doesn't... well, then this PR will come in handy.

aydjay commented 11 months ago

No trouble at all, thanks for the speedy response.

aydjay commented 8 months ago

Thanks again, this is great!

You're welcome, pleasure to work with you.