Closed tillig closed 1 month ago
Attention: Patch coverage is 50.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 78.57%. Comparing base (
4547d16
) to head (4e0ad9f
).
Files | Patch % | Lines |
---|---|---|
...tration/ExternalRegistryServiceMiddlewareSource.cs | 0.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I noticed that, while we have a set of test analysis rules, we didn't actually have static analysis running on the test assemblies.
This pull request fixes that:
Test.ruleset
to turn off rules that don't make much sense in tests.The vast majority of the issues were around things being created in tests and not disposed -
var x
instead ofusing var x
. It looks a little messy but it was easy enough to fix.The second largest number was around nested public types in test fixtures. I think this is something that was hit while cleaning up tests in Autofac.Extensions.DependencyInjection or similar - I remember a bit of churn on one of those. This fixes that. I tried to just mark things private as much as possible, though there were a couple I simply suppressed the issue on rather than try to move things around too much.
There are a few suppressions, mostly around: