Group Chat - Updates to resume - Githubissues

autogenhub / autogen

A programming framework for agentic AI. Discord: https://discord.gg/pAbnFJrkgZ

https://autogenhub.github.io/autogen/

Apache License 2.0

119 stars 23 forks source link

Group Chat - Updates to resume #20

Closed marklysze closed 2 months ago

marklysze commented 2 months ago

This PR addresses the need to populate a group chat's agents completely when resuming.

Additional fix to make resume_termination_string optional and default to None.

Why are these changes needed?

Issues have been identified when attempting to resume when messages were not fully populated.

Similarly, resume_termination_string not defaulting to None was overridden and needs to be restored. Added Optional as well.

Related issue number

Checks

[ ] I've included any doc changes needed for https://autogen-ai.github.io/autogen/. See https://autogen-ai.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[X] I've made sure all auto checks have passed.

sonichi commented 2 months ago

Thanks. Is there a test to cover resume and a_resume already?