Closed damianhxy closed 3 months ago
[!WARNING]
Rate Limit Exceeded
@damianhxy has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 35 minutes and 49 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 577c2ae6023ece31c6b22607b25effb29ff1e7f5 and 18fc27eed37452ac764e5c3768701dab7ed43422.
The recent updates aim to enhance the CMake multi-platform workflow and build process. The workflow now supports both Release
and Debug
configurations, providing increased flexibility. In CMakeLists.txt
, the logic dynamically sets CMAKE_BUILD_TYPE
based on conditions related to the release
option, falling back to Debug
when unspecified. These changes offer improved control over build configurations during CI.
File | Change Summary |
---|---|
.github/workflows/cmake-multi-platform.yml | Expanded build_type matrix options to include Debug alongside Release . |
CMakeLists.txt | Updated logic for setting CMAKE_BUILD_TYPE based on release conditions, defaulting to Debug . |
README.md | Revised build instructions, specifying commands for both debug and release versions. |
lib/logger/logger.h | Added [[maybe_unused]] attribute to the operator<< function in debug_logger struct. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This PR fixes the CI to correctly build release builds by changing the way that
CMAKE_BUILD_TYPE
is handled.It also adds debug builds to the CI.
To check: view the CI checks and ensure that the correct build type is displayed under the "Configure CMake" task. You can also experiment with combinations of
-DCMAKE_BUILD_TYPE
and-DRelease
, but note thatCMAKE_BUILD_TYPE
is cached.