search

autolab / Autolab

Course management service that enables auto-graded programming assignments.
http://www.autolabproject.com/
Apache License 2.0
752 stars 214 forks source link

Uglifier 3.0.4 cannot compress slickgrid properly (in production mode) #1046

Closed wlnirvana closed 4 years ago

wlnirvana commented 5 years ago

It seems the slickgrid js library uses some ES6 syntax, causing uglifier to throw the following error during assets precompiling.

SyntaxError: Unexpected token: name (el)

Upgrading to 3.2.0 resolved the issue.

travers-rhodes commented 5 years ago

I also had this problem. In addition to the change above, I also needed to update config.assets.js_compressor = :uglifier to config.assets.js_compressor = Uglifier.new(harmony: true) in /local/Autolab/config/environments/production.rb

wlnirvana commented 5 years ago

Yeah I forgot to mention exactly that. Thanks for the update @travers-rhodes :+1:

copperx commented 5 years ago

Upgrading to 3.2.0 resolved the issue.

Do you mind explaining how to tell the Docker image to run bundle install after changing Gemfile.lock to update uglifier?

wlnirvana commented 5 years ago

@copperx Sorry I was using a manual installation of Autolab, not the docker version.

wlnirvana commented 4 years ago

Closed by #1144