search

autolab / Autolab

Course management service that enables auto-graded programming assignments.
http://www.autolabproject.com/
Apache License 2.0
752 stars 213 forks source link

prepare for rubyzip transition #1433

Open cg2v opened 2 years ago

cg2v commented 2 years ago

Seen on bundle install. Looks like autolab will be affected (Archive.create_zip)

RubyZip 3.0 is coming!

The public API of some Rubyzip classes has been modernized to use named parameters for optional arguments. Please check your usage of the following classes:

  • Zip::File
  • Zip::Entry
  • Zip::InputStream
  • Zip::OutputStream

Please ensure that your Gemfiles and .gemspecs are suitably restrictive to avoid an unexpected breakage when 3.0 is released (e.g. ~> 2.3.0).

damianhxy commented 2 years ago

Change required should be Zip::Entry.new(zos, "#{File.basename(filepath)}", nil, nil, nil, nil, nil, nil, ctimestamp) --> Zip::Entry.new(zos, "#{File.basename(filepath)}", time: ctimestamp)