Mandatory nicknames

[droh]

If a user without a nickname visits the site, they should be forced to give themselves a nickname. This was how the previous autolab system worked, but somehow this behavior disappeared in the new system.

[dlbucci]

What is the reason for this? I removed this check when I rewrote some CUD editing logic, but I don't see why users can't leave their nickname blank.

[droh]

If users don't have nicknames, then it messes up the scoreboards.

-- David O'Hallaron -- Prof of CS and ECE, Carnegie Mellon University -- GHC 7517, x8-8199 -- http://www.cs.cmu.edu/~droh

On Tue, Jan 27, 2015 at 3:02 PM, Daniel Bucci notifications@github.com wrote:

What is the reason for this? I removed this check when I rewrote some CUD editing logic, but I don't see why users can't leave their nickname blank.

— Reply to this email directly or view it on GitHub https://github.com/autolab/Autolab/issues/196#issuecomment-71717354.

[jez]

Is this still an issue?

[icanb]

I think so. We should enforce users to have nicknames if the assessment has scoreboard module. Perhaps redirect them to a set nickname page?

[icanb]

At some point we'll also want to collect things like public keys. So maybe we can have a fill your information page where we ask for all the required info?

[jez]

We already have that page, and I'm pretty sure we already have this check:

https://github.com/autolab/Autolab/blob/master/app/controllers/application_controller.rb#L217

[jez]

If there's an issue, it might just be that we need to check that condition in more places?

[jez]

@autolab/developers I think this is fixed now, right?

[icanb]

Yes, it's fixed.