Closed damianhxy closed 4 months ago
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Use instance variables instead of flash to properly render roster import errors with large numbers of duplicates.
Motivation and Context
Currently, roster errors are propagated to the view using a flash. However, this results in a cookie overflow error when there are too many duplicates. By using instance variables, we can avoid this problem.
Closes #906
How Has This Been Tested?
roster_duplicates.csv roster_noduplicates.csv
Before PR - duplicates
After PR - duplicates
Also check that uploading rosters with no errors (
roster_noduplicates.csv
) works as expected.Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting