autolab / Autolab

Course management service that enables auto-graded programming assignments.
http://www.autolabproject.com/
Apache License 2.0
743 stars 209 forks source link

Added a button to release/unrelease grades #2081

Closed dwang3851 closed 4 months ago

dwang3851 commented 4 months ago

Description

Screenshots:

image image

Motivation and Context

-Currently, scores can only be released all at once, or through the individual problems on a gradesheet

How Has This Been Tested?

Types of changes

Checklist:

coderabbitai[bot] commented 4 months ago
Walkthrough ## Walkthrough The recent updates focus on enhancing the flexibility and intuitiveness of grade release mechanisms within a learning management system. Notably, the changes introduce the ability to release or unrelease individual student grades and refine the logic behind grade visibility and deadline adherence. This is achieved through modifications across controllers, models, views, and configurations, streamlining the process for instructors and TAs and addressing specific user needs for more granular control over score dissemination. ## Changes | File Path | Change Summary | |-----------|----------------| | `app/controllers/submissions_controller.rb` | Added `release_student_grade` and `unrelease_student_grade` actions with updated `before_action` callbacks. | | `app/helpers/submission_helper.rb` | Added an empty line. | | `app/models/submission.rb` | Added `problems_released?` method; refactored `grades_released?`. | | `app/views/.../viewGradesheet.html.erb`, `app/views/submissions/view.html.erb`, `app/views/submissions/_grades.html.erb` | Updated to support conditional grade release display and logic. | | `app/assets/javascripts/annotations.js`, `app/views/submissions/view.js.erb` | Enhanced grade release button functionality and rendering. | | `app/views/assessments/_handin_form.html.erb` | Refactored late submission logic and form submission adjustments. | | `config/routes.rb` | Added routes for `release_student_grade` and `unrelease_student_grade`. | | `db/schema.rb` | Database schema adjustments including type changes and added limits. | ## Assessment against linked issues | Objective | Addressed | Explanation | |-----------|-----------|-------------| | Allow release of individual student scores (#2063) | ✅ | | | Simplify the grade release process and address grading deadline confusion (#1717) | ❓ | The changes seem to support more granular control over grade releases, which could simplify the process, but it's unclear if the grading deadline confusion is directly addressed. | ## Related issues - **autolab/Autolab#1717**: This issue discusses refining the grading deadline to make it less confusing and more intuitive. The changes in this PR, particularly those enhancing the control over grade release, could indirectly address concerns raised in this issue by providing more flexibility in how and when grades are released, potentially making the grading deadline less of a bottleneck.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
damianhxy commented 4 months ago

LGTM, other than that the buttons do not update when annotations are created (e.g. a nil score is now non-nil and unreleased).