Closed damianhxy closed 4 months ago
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
I think it would be better if the whole line is new, to just remove the highlighting and have the line highlighted light green.
For eg, in this case, maybe just the light green highlight without the dark green.
Actually, maybe something like, if there are more than a percentage difference between two functions, just use light highlighting to show the entire function as a difference (if that makes sense).
Not sure if this is possible or not, but I think you can specify configurations of lines/words and the maximum number of configurations so that might fix this.
Also, I am a little confused about the selective strong highlighting. If these are 2 extremely different files so shouldn't everything be light green?
Personally prefer non-synchronized scrolling on both files, especially if file sizes are pretty different.
I think it would be better if the whole line is new, to just remove the highlighting and have the line highlighted light green.
Seems to be a limitation of the library, as I don't see a way to specify a "line similarity score threshold".
In general, there is no semantic info associated with a diff, so the library can and will match stuff like whitespace, brackets, and parenthesis.
Personally prefer non-synchronized scrolling on both files, especially if file sizes are pretty different.
Discussed offline as a won't change, since it would make comparisons more tedious in general and doesn't really bring any benefit.
Description
Motivation and Context
Closes #2090 Closes #1743
How Has This Been Tested?
Version switching on autograder output
Now able to switch between versions when viewing autograder output. Will always go to the immediate next / previous version, with a message if the output does not exist.
Output exists (and autograder exists)
Note the "Run Autograder" button
Output does not exist, autograder exists
Note the message, and the "Run Autograder" button
Output does not exist, autograder does not exist
Note the message, and NO "Run Autograder" button
Code Diff Viewer
Text file - changes exist![Screenshot 2024-02-18 at 00 57 37](https://github.com/autolab/Autolab/assets/9074856/dffe7977-d68b-407e-acb0-d09fec207b7b)
Text file - no changes![Screenshot 2024-02-18 at 00 57 40](https://github.com/autolab/Autolab/assets/9074856/c56737d2-19bb-4e30-9bd6-8cb7e2790286)
Version 1 of a file![Screenshot 2024-02-18 at 00 57 08](https://github.com/autolab/Autolab/assets/9074856/ea3b6cb3-7686-472d-9efa-616e91f195f7)
Other error, e.g. viewing a PDF or Binary file![Screenshot 2024-02-18 at 00 57 23](https://github.com/autolab/Autolab/assets/9074856/a75b8ced-688e-4cee-bd66-f4477fb99ef6)
Autograder Output![Screenshot 2024-02-18 at 00 58 32](https://github.com/autolab/Autolab/assets/9074856/1c8143a2-6bb5-4278-bfe3-606fc25ab854)
Large files![Screenshot 2024-02-18 at 00 56 55](https://github.com/autolab/Autolab/assets/9074856/7358f4da-34ba-4c6f-8728-dda418d8dba1)
Height tweaks
Before (CMU prod)![Screenshot 2024-02-18 at 01 00 52](https://github.com/autolab/Autolab/assets/9074856/64095867-f491-4137-bda2-2faf93ec1580)
After![Screenshot 2024-02-18 at 01 00 57](https://github.com/autolab/Autolab/assets/9074856/8b90a405-4328-4aba-8668-076767aa5732)
With announcements![Screenshot 2024-02-18 at 01 02 24](https://github.com/autolab/Autolab/assets/9074856/120aed9c-f135-4889-a502-b2c0701b4878)
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting