coderabbitai[bot]
commented
4 months ago Walkthrough
## Walkthrough The recent updates aim to enhance the functionality of scoreboards by enabling the inclusion of instructors in the display based on a new setting. These changes span across the controller, view files, and database schema. A migration introduces a new boolean column to support this feature, while the user interface is updated to provide control over this setting. Additionally, improvements in the view files enhance usability and presentation. ## Changes | File Path | Change Summary | |-------------------------------------------------------------|----------------------------------------------------------------------------------------------------| | `app/controllers/scoreboards_controller.rb` | Updated `show` method to include instructors if `@scoreboard.include_instructors` is true; `scoreboard_params` now permits `:include_instructors`. | | `app/views/scoreboards/_form.html.erb` | Removed outdated paragraph; added checkbox for including instructors, `help_text` attribute, and adjusted formatting. | | `app/views/scoreboards/show.html.erb` | Modified conditional logic using `unless`; corrected loop structure for table columns. | | `db/migrate/20240208143255_add_include_instructors_to_scoreboard.rb` | Added migration for `include_instructors` boolean column in `scoreboards` table. | | `db/schema.rb` | Added `include_instructors` boolean column with default value `false` to `scoreboards` table. |Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This allows instructors to choose to include themselves and CAs on assessment scoreboards if they want, on a per-scoreboard basis.
Description
Instructors can check the box to include instructors on scoreboards on the "scoreboard settings page." If this is checked, instructors and CAs will be included in the scoreboard.
Motivation and Context
Professors want to compete with their students. A very old version of Autolab included everybody by default. There was an update that removed instructors. Some instructors want to be included, while others don't. Now they can choose.
How Has This Been Tested?
I created a couple scoreboards, verified instructors aren't included by default, checked the checkbox, verified instructors are now included on the scoreboard, unchecked the checkbox, verified instructors disappeared from the scoreboard.
Types of changes
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for linting