Added a button to show students with missing submissions

dwang3851 commented 4 months ago

Description

Added a button to toggle between showing students with completed submissions and all students on the view gradesheet screen
By default, will only show students with completed submissions
Use the viewall param in the url to accomplish this behavior Screenshots:

Motivation and Context

Easier than sorting by submissions a couple times
Illiano asked for it
Resolves #2080

How Has This Been Tested?

Tested in local environment from instructor and TA account
Used an assessment that had both missing and non-missing submissions
Ensured that all non-missing submissions were present before the button is toggled, and that all submissions were present when it was not
Ensured this behavior remained consistent with multiple button clicks, and for both instructors and TAs

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
[ ] My change requires a change to the documentation, which is located at Autolab Docs
[ ] I have updated the documentation accordingly, included in this PR

Other issues / help required

Noticed current bug where the button to sort submissions is broken on the first click, and resolves itself after two more clicks

If unsure, feel free to submit first and we'll help you along.

coderabbitai[bot] commented 4 months ago

Walkthrough

## Walkthrough The update introduces functionality to manage the release of student grades in assessments, including toggling the display of missing submissions on the gradesheet as a configurable option. This encompasses backend changes for grade management, helper methods for release status checks, frontend modifications for user interaction with grades visibility, and routing adjustments to support these actions. The changes aim to enhance instructor control over grade visibility and streamline the grading process by addressing specific user feedback. ## Changes | Files | Change Summary | |--------------------------------------------------------------|--------------------------------------------------------------------------------------------------| | `app/controllers/submissions_controller.rb` | Updated `before_action`, added `release_student_grade` and `unrelease_student_grade` methods. | | `app/helpers/submission_helper.rb` | Added `released` method for checking release status of problem scores. | | `app/views/assessments/viewGradesheet.html.erb` | Added URI handling, localStorage JS functions, and a toggle for viewing all or completed submissions. | | `app/views/submissions/_grades.html.erb` | Added display logic for released/unreleased scores. | | `app/views/submissions/_release_grades.html.erb` | New functionality for releasing/unreleasing grades. | | `app/views/submissions/view.html.erb` | Added rendering of "release_grades" partial template. | | `config/routes.rb` | Added routes for `release_student_grade` and `unrelease_student_grade`. | | `db/schema.rb` | Minor modification, no significant change in functionality. | ## Assessment against linked issues | Objective | Addressed | Explanation | |---------------------------------------------------------------------------|-----------|-------------| | Make displaying of missing submissions on gradesheet a toggleable option (#2080) | ✅ | | The changes directly address the primary objective outlined in issue #2080 by implementing a toggleable option for displaying missing submissions on the gradesheet. This is achieved through modifications in the `viewGradesheet.html.erb` file, where logic and a user interface element (checkbox) have been introduced to allow instructors to choose between viewing all students or only those with completed submissions, aligning with the issue's requirements for enhanced usability and customization in the grading process.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.

20wildmanj commented 4 months ago

Note: for the "How Has This Been Tested?" portion of the PR you should outline the specific steps you took to test the new behavior (and also how you want your reviewer to test the PR, taking note to what the reviewer should be looking for)

autolab / Autolab