Improve MOSS robustness with tarfiles

Description

Avoid turning files into dotfiles when preparing an assessment for MOSS, by prepending MOSS to all filenames after replacing slashes with hyphens.

Note: an alternative might be to use File.cleanpath (docs). However, it can lead to name collisions since it would simply strip out any .. in the name.

Motivation and Context

Closes #2094

How Has This Been Tested?

Extract Archive.zip. Contains four tar file submissions

tarnormal.tar: files are tarred "normally", i.e. tar -cf tarnormal.tar autograde-Makefile dave.c hello.c
tarrelative.tar: files are tarred using ./, i.e. tar -cf tarrelative.tar ./autograde-Makefile ./dave.c ./hello.c
tartraversal.tar: files traverse one level up first, i.e. tar -cf tartraversal.tar ../MossTest/autograde-Makefile ../MossTest/dave.c ../MossTest/hello.c
tartraversal2.tar: files traverse two levels up first, i.e. tar -cf tartraversal2.tar ../../Desktop/MossTest/autograde-Makefile ../../Desktop/MossTest/dave.c ../../Desktop/MossTest/hello.c

Submit the files one at a time -> after each submission, check that MOSS works for the assessment (i.e. select isArchive and send *hello.c

BEFORE Screenshot 2024-02-26 at 15 40 21

AFTER (possibly failed by exceeding request limit, nonetheless the error is different) Screenshot 2024-02-26 at 15 40 40

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
[ ] My change requires a change to the documentation, which is located at Autolab Docs
[ ] I have updated the documentation accordingly, included in this PR

Walkthrough

### Walkthrough The modification addresses an issue where MOSS was unable to locate files in archives if the pathnames started with `./`, leading to files being incorrectly marked as dotfiles. This was resolved by prepending "MOSS" to the `pathname` before the `destination` path is set, ensuring that files are correctly named and discoverable by MOSS, effectively handling the flattening of nested directories without creating dotfiles. ### Changes | File Path | Change Summary | |-----------------------------------|--------------------------------------------| | `app/controllers/courses_controller.rb` | Prepend "MOSS" to `pathname` before setting `destination` path | ### Assessment against linked issues | Objective | Addressed | Explanation | |-----------|-----------|-------------| | #2094: MOSS fails to find files in archives whose pathnames start with ./ | ✅ | |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.

autolab / Autolab