Closed damianhxy closed 6 months ago
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Also self-assign groups is checked by default when creating a new assessment, only way to uncheck it is to do so in assessment settings. I think maybe it would be better to let instructors check/uncheck it before/while creating an assessment too?
Done:
I also took the liberty of fixing the breadcrumbs for the creation page
Description
index
,new
,show
)@grouplessCUDs
which is never shown onshow
ornew
pagesMotivation and Context
Closes #2115
How Has This Been Tested?
Create assessment with group size 3 and student self-assignment enabled
student1
, create a group withstudent2
student3
, request to join the groupstudent3
can choose to leave the groupstudent1
, cancel invite tostudent2
and then leave the group. Group will be disbanded.student3
is now without a groupstudent1
, create a new group withstudent2
instructor
, kickstudent1
- group not disbandedinstructor
, kickstudent2
- group disbandedCreate assessment with group size 3 and student self-assignment disabled
student1
, see message that you can't create or join groupsinstructor
, create group withstudent1
- observe thatstudent1
is automatically confirmed andinstructor
is not addedinstructor
, add yourself to the group successfully. Then kick yourself.student1
view group and see message that you can't add members to the group.In general, test that behavior makes sense.
Screenshots
Instructor (in group), student-assignment allowed / not allowed
Note: when student-assignment allowed, need to self-approve. If not allowed, automatically approved.
Instructor (not in group), student-assignment allowed / not allowed
Confirmed student, student-assignment allowed
Confirmed student, student-assignment not allowed
Group-confirmed student, student-assignment allowed
Group-confirmed student, student-assignment not allowed
Member-confirmed student, student-assignment allowed
Member-confirmed student, student-assignment not allowed
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting