Better error messages for autograder settings

Description

Change bounds of autograder timeout to be inclusive (10 to 900 seconds)
Remove unnecessary javascript code from form (handled by Materialize)
Change to new style path helpers
Better frontend validation of autograde_image (present and length <= 64) and autograde_timeout (numeric field + bounds), show bounds in help text
Remove unmaintained/deprecated dynamic_form gem + all occurrences of error_messages
Make edit assessment update failure message consistent
Use notice instead of error for warn messages so that it doesn't overwrite update failure messages

Motivation and Context

Removes all f.error_messages occurrences + removes the dynamic_form gem as the gem has not really been maintained since Rails 3 (https://rubygems.org/gems/dynamic_form/versions/1.1.4?locale=en)

Besides, it isn't particularly necessary.

Closes #2141

How Has This Been Tested?

Autograde timeout can now be set to 10s / 900s inclusive
Observe helptext explaining that timeout "Must be between 10s and 900s, inclusive."
When choosing a Autograder Makefile or Autograder Tar, the file name still updates correctly
Make frontend validation better reflect backend validation
- autograde_image can't be empty
- autograde_image can't be longer than 64 chars
- autograde_timeout must be numeric, and between 10 and 900 inclusive
If backend validation fails (you have to disable the frontend validation first), helpful error message displayed

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
[ ] My change requires a change to the documentation, which is located at Autolab Docs
[ ] I have updated the documentation accordingly, included in this PR

Summary by CodeRabbit

New Features
- Added more structured and informative feedback for late submissions and assessment configuration errors.
- Enhanced validation for autograder timeout settings, ensuring values are between 10 and 900 seconds.
Bug Fixes
- Updated flash messages across various actions for clearer communication.
- Improved form validation and error messaging, particularly for autograder configurations.
Refactor
- Removed outdated dynamic_form gem and associated error message calls in forms, streamlining error handling.
Style
- Updated form fields for autograder configurations, including changing input types and adding constraints.

Walkthrough

## Walkthrough The recent updates focus on enhancing user feedback and form validation within the application. Notably, the removal of the outdated `dynamic_form` gem and its associated error message methods marks a shift towards more modern and structured error handling practices. Additionally, adjustments in the `AutogradersController` improve the clarity of error messages by incorporating model validation errors directly into flash messages. These changes, alongside specific validations for `autograde_timeout` and refinements in form fields, aim to provide a more informative and user-friendly experience. ## Changes | Files | Change Summary | |-------|----------------| | `Gemfile` | Removed `dynamic_form` gem. | | `app/controllers/assessments_controller.rb`
`app/controllers/autograders_controller.rb` | Updated flash messages for better user feedback; in `autograders_controller.rb`, also added error messages concatenation and set `flash[:html_safe]`. | | `app/models/autograder.rb` | Modified `autograde_timeout` validation. | | `app/views/.../edit.html.erb`
`app/views/.../new.html.erb`
(multiple views) | Removed `f.error_messages` calls. | | `app/views/autograders/_form.html.erb` | Updated form fields with additional attributes and constraints; removed JavaScript block. | ## Assessment against linked issues | Objective | Addressed | Explanation | |-----------|-----------|-------------| | AutogradersController methods should use `@autograders.errors` in flash (#2141) | ✅ | |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

autolab / Autolab