search

autolab / Tango

Standalone RESTful autograding service
http://www.autolabproject.com/
Apache License 2.0
48 stars 59 forks source link

Make volumes paths explicit to avoid assuming cwd #169

Closed fanpu closed 4 years ago

fanpu commented 4 years ago

In the Tango deployment instructions for Docker on Ubuntu 18.04, os.cwd() is unable to find the current directory of the Tango installation. I'm guessing most likely that the problem arose because of a difference in how supervisord or the OS determines the current working directory of a service. Previously, the cwd was probably inherited from where the supervisor daemon was started, but this implicit behavior is probably undefined behavior and we shouldn't be relying on it.

This PR forces the volume directory to be explicitly specified.

fanpu commented 4 years ago

LGTM. Removes mentioned undefined behavior. However, I was wondering if the need to specify volume directory was mentioned anywhere / added in the tango documentation (under the Docker section).

I'll be addressing this shortly. Thanks for reviewing this!