search

autolab / Tango

Standalone RESTful autograding service
http://www.autolabproject.com/
Apache License 2.0
48 stars 60 forks source link

Allow failed posting of autograding results in Tango to be retried #217

Closed xinyis991105 closed 2 years ago

xinyis991105 commented 2 years ago

This is based on a customized fix from Chaskiel. See https://github.com/cg2v/Tango/commit/885b9649a1021be9c57748c3a49ff771a8a2c04b.

@cg2v Thanks for suggesting the change! Let us know if you think it's ok for us to adopt it. We will also do further testing to make sure Tango functions normally before we merge it in.

cg2v commented 2 years ago

I think the summary here is confusing. What's being retried is posting the autograding results back to the frontend, not a failed job itself.

That said, there's no external dependencies to worry about, and this should not have any effect unless the initial POST of the autograde_done callback fails.

xinyis991105 commented 2 years ago

Thanks for the clarification!

xinyis991105 commented 2 years ago

We need to upgrade the requests library to make the Retry method work. Tested by:

  1. Single submission grading.
  2. Bulk submission grading.