coderabbitai[bot]
commented
1 month ago 📝 Walkthrough
## Walkthrough The changes in the pull request focus on enhancing the `tango-cli.py` script by introducing new command-line arguments and modifying existing functions. A new argument `--runJobPoll` allows users to run a job from a specified directory and poll its status. This leads to the creation of the `tango_runJobPoll` function, which manages job submission and polling. The existing `tango_runJob` function is updated to return the job ID, facilitating the polling process. Additional modifications include updates to the `tango_poll` and `tango_jobs` functions for improved job status handling. ## Changes | File | Change Summary | |--------------------------|-----------------------------------------------------------------------------------------------------| | clients/tango-cli.py | - Added `--runJobPoll` argument.- Introduced `tango_runJobPoll()` function.
- Updated `tango_runJob()` to return job ID.
- Modified `tango_poll` and `tango_jobs` for conditional responses based on `--runJobPoll` presence.
- Imported new modules: `time`, `datetime`, `uuid`. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant CLI participant JobManager participant Poller User->>CLI: Run command with --runJobPoll CLI->>JobManager: tango_runJob() JobManager-->>CLI: Return job ID CLI->>Poller: tango_runJobPoll(job ID) Poller->>JobManager: Check job status JobManager-->>Poller: Return job status Poller->>CLI: Display job status Poller->>JobManager: Check job status (repeat) JobManager-->>Poller: Return job status Poller->>CLI: Display job status Poller->>JobManager: Check for completion or timeout JobManager-->>Poller: Job completed or timed out Poller->>CLI: Final job status ```
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Add new CLI option runJobPoll to allow for easy lookup of a job throughout its lifecycle by first running the job, then checking both live and dead jobs for its inclusion, and then polling for output, concluding once the job has exited.
To test: run
python clients/tango-cli.py -P {YOUR PORT} -k {YOUR KEY} --runJobPoll clients/job1/ --image autograding_imagesee result as follows: