search

automatic-ripping-machine / automatic-ripping-machine

Automatic Ripping Machine (ARM) Scripts
https://b3n.org/automatic-ripping-machine
MIT License
2.49k stars 282 forks source link

🔧 Handbrake Profile selection in the settings should be a dropdown menu #1110

Open SylvainMT opened 4 months ago

SylvainMT commented 4 months ago

Is this feature missing in the latest version?

Is your feature request related to a problem? Please describe.

Not a problem per se, but the current use of using a text field is error-prone. Making it difficult for users to know what the profile options are.

Describe the solution you'd like?

In the Ripper Settings page, the settings;

Should be a dropdown list. The dropdown list should be dynamically populated from the results of HandBrakeCLI -z.

Further, I would also suggest that a new field called "HB_PRESET_FILE" should be present, it should be a browse field to select a preset file and upload it to the ARM machine for its use. (The preset file is something that can be easily created using the HandBrake UI, allowing the user some fine-grained control over how Handbrake processes the transcode.) If the filed is populated, when ARM calls HandBrakeCLI it should add the option: HandBrakeCLI --preset-import-file={ValueOf_HB_PRESET_FILE} The preset list in the settings page could also be prepopulated from the same preset file with HandBrakeCLI -z --preset-import-file={ValueOf_HB_PRESET_FILE}

Describe alternatives you've considered?

I have been doing this manually. Copy-pasting the name of the HB preset from the terminal directly in the arm.yaml.

I've also been using the HB_ARGS_DVD AND HB_ARGS_BD field to set a custom preset file.

Anything else?

HandBrakeCLI Commandline Reference: https://handbrake.fr/docs/en/1.7.0/cli/command-line-reference.html HandBrakeCLI Commandline Options: https://handbrake.fr/docs/en/1.7.0/cli/cli-options.html

Code of Conduct

microtechno9000 commented 4 months ago

Agree, a lot of the config settings should be a list or fixed so users don't break things. Also makes it easier to configure without reading the wiki

Its on the list I plan to resolve, with 3.0

SylvainMT commented 4 months ago

Willing to work on it, once you guys have firmed up the code for V3.0 It was suggested that the issue should be posted so it can be tracked, so that is what I did :)

microtechno9000 commented 4 months ago

All good, saw the discussion on discord, I should have mentioned.

Adding context here for other users who might see this post.

shitwolfymakes commented 4 months ago

Seconded, per the chat on Discord this is a perfect issue to start on as part of 3.1. Best to keep feature additions separate from the total rewrite we're shipping in 3.1