automatic-ripping-machine / automatic-ripping-machine

Automatic Ripping Machine (ARM) Scripts
https://b3n.org/automatic-ripping-machine
MIT License
2.71k stars 287 forks source link

🐋 Docker container updates excessively often #1243

Open mihawk90 opened 3 hours ago

mihawk90 commented 3 hours ago

Is there an existing issue for this?

Does this issue exist in the latest version?

Describe the bug?

As previously discussed in #1241, the Docker container is being updated nightly even when there have been no changes to the code. Seemingly this is done to keep MakeMKV up to date. This is reasonable of course, but MakeMKV doesn't update that often. Looking at the Release History the updates seem to happen roughly every 4 months or so, so a daily rebuild seems excessive.

The problem with this is for people that want to keep their containers up-to-date either via automation (e.g. watchtower and the like) or via notifications (e.g. TrueNAS Scale apps) as it alerts or updates every day even with no changes. With the size of the container this is quite a strain on bandwidth and possibly storage depending on configuration.

The container is already rebuilt on every commit to main. Outside of that ideally it would only be rebuilt when MakeMKV actually updates. Unfortunately I don't know much about Dependabot, but maybe it could be automated there? If Dependabot is not an option it might be possible to instead run a daily CI to check the latest version and if there is an update, either commit automatically or at least open a PR automatically.

The code already fetches the latest version automatically: https://github.com/automatic-ripping-machine/arm-dependencies/blob/f949ac0c9da5dbbf3ec584dc3bcbd31842e20127/scripts/install_makemkv.sh#L24-L27

So using that snippet to instead update a variable should be possible. Both tianon's as well as jlesage's Dockerfile do this, although they seem to update the version manually:

https://github.com/tianon/dockerfiles/blob/084328c1fce79c2667934929913a9e9b29be2f65/makemkv/Dockerfile#L18 https://github.com/jlesage/docker-makemkv/blob/c597f06e1c5c48713f82fb9af91198a07bff7f51/Dockerfile#L11

Besides, I might be wrong on this but I think there is some leniency regarding updating the version anyway. If I recall correctly even the beta key allows an older version for a while.

To Reproduce

  1. Install Docker container
  2. Check for updates the next day

Or check the Dockerhub Tags

Built from source files ?

What architecture are you seeing the problem on?

amd64

Expected behavior?

The container should update when there are actual updates

Relevant log output

No response

Anything else?

No response

Code of Conduct

github-actions[bot] commented 3 hours ago

If youre having issues, please remember to read the wiki and follow the instructions carefully