search

automation-stack / electron-sudo

Electron subprocesses with administrative privileges, prompting the user with an OS dialog if necessary.
MIT License
382 stars 55 forks source link

Honor the MIT license #22

Closed jorangreef closed 8 years ago

jorangreef commented 8 years ago

electron-sudo is a heavily refactored fork of sudo-prompt and still retains several portions of copyrighted content copied verbatim from there.

electron-sudo used to include the sudo-prompt license, but this has recently been removed, along with all reference to sudo-prompt.

I would appreciate it if you continue to honor the MIT license terms by at least including the sudo-prompt license in your project.

automation-stack commented 8 years ago

@jorangreef At this moment electron-sudo uses only adopted from sudo-prompt bundled applet. I added a link to author, thanks for the tip.

OS X, uses bundled applet (inspired by Joran Dirk Greef)

jorangreef commented 8 years ago

@automation-stack I can point you to several other places where you are using sudo-prompt content without including the required MIT license. Your inclusion of any content whatsoever is enough to obligate you to include the entire MIT license file as directed.

automation-stack commented 8 years ago

@jorangreef Please point to me all other places where electron-sudo uses sudo-prompt content, i will fix this.

automation-stack commented 8 years ago

@jorangreef Added MIT license for adopted component https://github.com/automation-stack/electron-sudo/tree/master/src/bin/applet.app

jorangreef commented 8 years ago

Thanks, I see you've now removed the Concurrency section from the README. There is still https://github.com/automation-stack/electron-sudo/blob/master/src/lib/sudoer.js#L114 but you're welcome to it. All the best with your open source work.

automation-stack commented 8 years ago

@jorangreef Yes, concurrency approach in electron-sudo was changed to separate prompt on each call on all supported platforms.