Closed olivierobert closed 11 months ago
Hello, Olivier thank you for letting me know. I will proceed to add RSpec for core logic.
As a hint, you will need to record the request to Google. A team such as https://github.com/vcr/vcr is usually the easiest go-to tool.
Hello Olivier I try to use Webmock when GoogleScraper.call here pull-request. I'm not sure if I do it the right way.
The usage of Webmock is sound. The implementation is sufficient to show you can research a new tool and apply it 💪
Issue
Automated tests do not cover the core business logic: scraping.
Expected
While 100% test coverage is not required for this code challenge, all critical paths of the application should be unit-tested (and, ideally, UI-tested). So the following should be covered: