Closed scotttrinh closed 3 years ago
Thanks, I was about to ask you for help! This also fixes the browser tests for me, but I noticed that after this PR Karma is only running 60 tests in each browser, whereas previously it was running 562. I think it's only running the tests in test/typescript_test.ts
but not those in test/*test.js
. Do you know how to get it to run all the tests again?
Oh interesting. Sure, lemme take a look and see if I can figure out what's happening.
I will go ahead and merge this in order to make Travis CI happy again, so that I can make a release, but let's try to fix the test runner in a follow-up PR.
The browser tests broke during the refactor at #396 complaining about not being able to iterate over undefined "chunks":
That reminded me of the issue that was noted in that original PR where setting this
chunkLoading
property didn't seem to make a difference for running webpack, but it looks like it does matter for actually using the bundle! 😅I've run
yarn run browsertest
locally and it seems to work, so hopefully this fixes the issue.