search

automerge / automerge-go

MIT License
98 stars 6 forks source link

Upgrade automerge to 0.5.0 #21

Closed stephen closed 1 year ago

stephen commented 1 year ago

I attempted to pull in automerge-rs 0.5.0 which required some minor changes.

stephen commented 1 year ago

I should also say my primary goal here is to fix possible corruption bugs mentioned here: https://github.com/automerge/automerge/issues/536#issuecomment-1518422998

ConradIrwin commented 1 year ago

Hey @stephen, thanks for this!

I've changed C.SIZE_MAX>>1 to C.PTRDIFF_MAX and merged it in.

For some reason when I do ./deps/rebuild.sh the libraries are a few hundred kbs smaller, so I've done that too. I wonder what the difference could be.

ConradIrwin commented 1 year ago

I'm considering a few breaking changes in https://github.com/automerge/automerge-go/pull/22, if you're using automerge-go I'd love your feedback.

Probably the biggest is to move from the JSON serializer to hand-rolling it; which is a lot more reliable for nested types.

stephen commented 1 year ago

thanks for looking!

unfortunately i’m not quite in a position to provide feedback - my use of automerge-go has been exclusively for syncing/backing up documents, so i haven’t actually used any of the manipulation codepaths in go

ConradIrwin commented 1 year ago

Sounds good :D. Seems like it would be unlikely to break anything for you then.