search

automerge / automerge-swift

Swift language bindings presenting Automerge
https://automerge.org/automerge-swift/documentation/automerge/
MIT License
216 stars 11 forks source link

exposing Automerge::get_marks through to Swift #186

Closed miguelangel-dev closed 2 weeks ago

miguelangel-dev commented 3 weeks ago

Bindings for being able to retrieve the marks of a given position without traversing the ops of the full document.

https://automerge.org/automerge/automerge/struct.Automerge.html#method.get_marks

heckj commented 3 weeks ago

Thanks @miguelangel-dev, I'll take a look in depth a little later today or tomorrow, WWDC is dominating my attention right now. In the meantime, Marks has some underlying changes that we should get in before dropping this in place - some API updates that align to the latest core library that I have in some commits in the WIP Blocks PR (#171). I'll pull those out of the existing PR and get those set up so we can merge them without waiting for the full detail work on the Blocks API

heckj commented 3 weeks ago

@miguelangel-dev I don't think there'll be a serious conflict, but go ahead and rebase over the #171 merge, and things should be good. Biggest detail change here was the internal API switching from Value to ScalarValue inside marks, which I wanted to get in if we were expanding the marks API with these bits.

miguelangel-dev commented 3 weeks ago

@miguelangel-dev I don't think there'll be a serious conflict, but go ahead and rebase over the #171 merge, and things should be good. Biggest detail change here was the internal API switching from Value to ScalarValue inside marks, which I wanted to get in if we were expanding the marks API with these bits.

Thanks for moving and merging. I have rebased it against #171 - it should be ready to review 🙏🏻

miguelangel-dev commented 3 weeks ago

Thanks both for the code review, I have addressed all your suggestions. It is ready for a second round 🙏🏻

miguelangel-dev commented 3 weeks ago

Sorry, added a latest minor change to revert an unnecessary public accessibility into the cursor c6798ffe4a6dacb43abe8ee6576c60345138c7eb